Repository navigation
feat(bigtable/accelerator): add --user-agent flag to daemon - #20341
Merged
Merged
Conversation
Add a --user-agent flag to the daemon binary so cross-language clients (e.g. the Python SDK) can identify themselves to the Bigtable service. The flag value is prepended to the daemon's own token, space-separated per the gRPC user-agent product-token convention, e.g. "python-bigtable/2.1.0 go-acc/v1.38.0". A blank flag leaves the daemon-token-only user agent unchanged. Also shorten the daemon's own token from "cbt-go-accelerator/v<ver>" to "go-acc/v<ver>". Composition lives in the exported ComposeUserAgent helper, covered by a new unit test. Change-Id: I0a0330b1d9a43845a0b36f3babeac89096066591
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for custom user-agent prefixes in the Bigtable accelerator daemon. It renames the default user-agent token to "go-acc/v" and adds a ComposeUserAgent function to prepend caller-supplied prefixes (such as from cross-language clients like the Python SDK) to the daemon's token. Additionally, a new -user-agent command-line flag is introduced in the main command to configure this prefix, along with corresponding unit tests. There are no review comments to address, and the implementation looks solid with no additional feedback to provide.
sushanb
approved these changes
Aug 7, 2026
sushanb
pushed a commit
that referenced
this pull request
Aug 28, 2026
🤖 I have created a release *beep* *boop* --- ## [1.53.0](bigtable/v1.52.0...bigtable/v1.53.0) (2026-08-27) ### Features * **bigtable/accelerator:** Add --user-agent flag to daemon ([#20341](#20341)) ([6b33c06](6b33c06)) * **bigtable/accelerator:** Add daemon binary with identity verification ([#20330](#20330)) ([2f9cf89](2f9cf89)) * **bigtable/accelerator:** Add proxy channel scaffold owning a sessi… ([#20310](#20310)) ([d65ca7d](d65ca7d)) * **bigtable/accelerator:** Add stdin-EOF and parent-PID lifecycle wa… ([#20328](#20328)) ([dc1c6ae](dc1c6ae)) * **bigtable/accelerator:** Add UDS server with authenticated proxy i… ([#20320](#20320)) ([a837020](a837020)) * **bigtable/accelerator:** Add V2-to-session request adapters ([#20271](#20271)) ([4cb6f16](4cb6f16)) * **bigtable/accelerator:** Authenticate UDS callers with a stdin tok… ([#20324](#20324)) ([7847ab7](7847ab7)) * **bigtable/accelerator:** Dispatch MutateRow and single-row ReadRow… ([#20312](#20312)) ([c89f336](c89f336)) * Update API sources and regenerate ([#20369](#20369)) ([bfe3aaf](bfe3aaf)) * Update sources and regenerate ([#20399](#20399)) ([a6b5cdb](a6b5cdb)) ### Bug Fixes * **bigtable/internal/transport:** Drop redundant defer p.Close() in AFE picker tests ([#20311](#20311)) ([c05b767](c05b767)) * **bigtable:** Register c2p resolver + RLS balancer for accelerator daemon DirectPath ([#20362](#20362)) ([95f372f](95f372f)) * **bigtable:** Session client — set AllowNonDefaultServiceAccount on DirectPath dial ([#20343](#20343)) ([b9c76ec](b9c76ec)) * **bigtable:** Session client — single ownership + single-flight pool loading ([#20368](#20368)) ([f4ad950](f4ad950)) * **bigtable:** Session pool — re-drive creation after a never-activated close so the consecutive-failure breaker is reachable ([#20355](#20355)) ([ee74949](ee74949)) * **bigtable:** Use composed user agent as CSM client_name ([#20383](#20383)) ([cb02335](cb02335)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a --user-agent flag to the daemon binary so cross-language clients (e.g. the Python SDK) can identify themselves to the Bigtable service. The flag value is prepended to the daemon's own token, space-separated per the gRPC user-agent product-token convention, e.g. "python-bigtable/2.1.0 go-acc/v1.38.0". A blank flag leaves the daemon-token-only user agent unchanged.
Also shorten the daemon's own token from "cbt-go-accelerator/v" to "go-acc/v".
Composition lives in the exported ComposeUserAgent helper, covered by a new unit test.