Skip to content

feat(bigtable): expose a client option to disable direct access: - #14626

Merged
sushanb merged 6 commits into
googleapis:mainfrom
sushanb:config_directpath
May 22, 2026
Merged

sushanb merged 6 commits into
googleapis:mainfrom
sushanb:config_directpath

Conversation

@sushanb

@sushanb sushanb commented May 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sushanb
sushanb requested review from a team as code owners May 21, 2026 06:09
@sushanb
sushanb requested a review from nimf May 21, 2026 06:09
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label May 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a DisableDirectAccess field to the ClientConfig struct to allow users to disable DirectPath, refactoring the client initialization to conditionally configure dialers and feature flags. However, the review identifies a critical naming inconsistency where the field is defined as DisableDirectAccess but referenced as DisableDirectpath in multiple locations, which will result in compilation errors. The reviewer recommends renaming the field to DisableDirectPath to ensure consistency and adhere to Go naming conventions.

Comment thread bigtable/client.go Outdated
Comment thread bigtable/client.go Outdated
Comment thread bigtable/client.go Outdated
Comment thread bigtable/client.go Outdated
@sushanb
sushanb merged commit f22b29f into googleapis:main May 22, 2026
17 checks passed
sushanb added a commit that referenced this pull request May 27, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.15.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a
<details><summary>bigtable: v1.48.0</summary>

##
[v1.48.0](bigtable/v1.47.0...bigtable/v1.48.0)
(2026-05-26)

### Features

* expose a client option to disable direct access: (#14626)
([f22b29f](f22b29f5))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants