Repository navigation
fontconfig: handle when lang is string and not langset - #14853
Merged
Merged
Conversation
Fontconfig accepts strings when a langset is expected. This by itself is not a problem. But for some ungodly reason it can also *return* a string in place of a langset, for example when a `FcPattern` doesn't match any language and it falls back to `"en"`. Just why would you do this? What reason can there ever be to do this??????
pluiedev
force-pushed
the
pluie/jj-tyurmpmrlnzn
branch
from
October 26, 2026 09:45
f28954c to
f63124c
Compare
mitchellh
approved these changes
Oct 26, 2026
Member
Author
|
I think this should be part of the 1.4 milestone? Doesn't make sense to put it in 1.5 I think |
Contributor
|
Yes, automation error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fontconfig accepts strings when a langset is expected. This by itself is not a problem. But for some ungodly reason it can also return a string in place of a langset, for example when a
FcPatterndoesn't match any language and it falls back to"en". Just why would you do this? What reason can there ever be to do this??????