Repository navigation
core: size click_state to hold every mouse button - #14759
Merged
Merged
Conversation
MouseButton.max is the largest enum value (11), not a count, so an array of that length has no slot for .eleven. Recording a press or release of button 11 indexed past the end, which panics in safe builds. Size the array max + 1 and correct the doc comment on max that suggested using it directly as an array length.
tristan957
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MouseButton.max is the largest enum value (11), not a count, so an array of that length has no slot for .eleven. Recording a press or release of button 11 indexed past the end, which panics in safe builds.
Size the array max + 1 and correct the doc comment on max that suggested using it directly as an array length.
AI disclosure: Claude Code was used in the preparation of this PR