Repository navigation
terminal: TBC with no parameter clears the tab stop at the cursor - #14644
Merged
Merged
Conversation
The parameter of TBC (CSI Ps g) defaults to 0, which clears the tab stop at the cursor, but a bare CSI g has no parameters at all, and the stream logged it as an invalid tab clear command and dropped it. Treat it as 0. This fixes esctest's TBC_Default. In xterm (patch 412), a missing or zero parameter clears the tab stop at the cursor: https://github.com/ThomasDickey/xterm-snapshots/blob/bccd466414dc4ecb264a3824a6f1e41bebe65214/charproc.c#L4301-L4308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter of TBC (CSI Ps g) defaults to 0, which clears the tab stop at the cursor, but a bare CSI g has no parameters at all, and the stream logged it as an invalid tab clear command and dropped it. Treat it as 0.
This fixes esctest's TBC_Default.
In xterm (patch 412), a missing or zero parameter clears the tab stop at the cursor:
https://github.com/ThomasDickey/xterm-snapshots/blob/bccd466414dc4ecb264a3824a6f1e41bebe65214/charproc.c#L4301-L4308
AI disclosure: Claude Code was used in the preparation of this PR.