Repository navigation
terminal: stop line selection at prompt boundaries across blank cells - #14553
Merged
Merged
Conversation
Selecting a span of blank cells or whitespace between OSC 133 semantic boundaries could pull in neighboring prompt text and reverse the selection endpoints. The whitespace trims iterate with a `CellIterator` bounded by the end pin, but the iterator bounds only the row, so the trim ran past the end column into the next prompt. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
mitchellh
approved these changes
Oct 6, 2026
mitchellh
enabled auto-merge
October 6, 2026 16:06
mitchellh
disabled auto-merge
October 6, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a span of blank cells or whitespace between OSC 133 semantic boundaries could pull in neighboring prompt text and reverse the selection endpoints. The whitespace trims iterate with a
CellIteratorbounded by the end pin, but the iterator bounds only the row, so the trim ran past the end column into the next prompt.To reproduce: Run this script and triple-click either blank cell between
xandmon the first row. Before the fix, the selection reaches into the neighboring prompt text; after the fix, nothing is selected (like triple-clicking a blank row).AI disclosure: Initially created with the help of gpt-6 astra in codex. Iterated on, reviewed and tested by me.