Repository navigation
input: UTF-8 encode the button in 1005 mouse reports - #14532
Merged
Merged
Conversation
In UTF-8 mouse mode (DECSET 1005) the button value was written as a single raw byte. xterm encodes it as UTF-8 like the coordinates, so values from 128 (buttons 8 and 9) take two bytes. The raw byte made the report invalid UTF-8. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
mitchellh
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix UTF-8 mouse reporting (DECSET 1005) to UTF-8 encode the button value, as required by xterm’s specification.
Previously, buttons 8 and 9 (back/forward) produced a raw byte of
0xA0or0xA1, making the report invalid UTF-8. For example, pressing button 8 at column 1, row 1 produced:b'\x1b[M\xa0!!'b'\x1b[M\xc2\xa0!!'AI disclosure: Initially created with claude code using opus 5.5. Iterated on, reviewed and tested manually by me.