Repository navigation
terminal: preserve saved cursor position during repeated widening - #14478
Merged
Merged
Conversation
Fix saved cursors moving backward during repeated widening. Reflow now accounts for deferred line breaks and pending wrap when clamping tracked positions in trailing blanks. Starting with a 4-column terminal: 1. Output `abc`, then start a new line and output `AAA|`. 2. Save the cursor while in pending wrap (`ESC 7`). 3. Widen to 5 columns, then to 6 columns. 4. Restore the cursor (`ESC 8`) and output `X`. Current buggy behaviour: ``` abc AAX| ``` Fixed expected behaviour: ``` abc AAA|X ``` Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
Contributor
Author
|
Used this script to experiment with the issue and the fix: saved-wrap.py |
mitchellh
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix saved cursors moving backward during repeated widening. Reflow now accounts for deferred line breaks and pending wrap when clamping tracked positions in trailing blanks.
Starting with a 4-column terminal:
abc, then start a new line and outputAAA|.ESC 7).ESC 8) and outputX.Current buggy behaviour:
Fixed expected behaviour:
AI disclosure: Created with codex using gpt-6 astra. Iterated on, reviewed and tested by me.