Repository navigation
gtk: never resize a split smaller than one cell - #14476
Conversation
042a749 to
ac21805
Compare
|
One little bug I found with this is when you resize a split (with keybinds) in one direction until you have reached the minimum size, you can still further decrease the split ratio stored in the split tree until it is 0 by pressing your bind. Nothing will change visually, but if you then resize again in the other direction you might have to press your keybind multiple times before something happens or the resize will be too small, depending on the resize amount specified in your keybind. |
@dkinzler should now be addressed. |
Also clamp keyboard split resizes to the split size, which fixed an assertion failure when resize_split moved past the edge of a split. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@thomasfedb can you rebase this onto current main? |
10677ca to
cc84a42
Compare
@jcollie done! |
jcollie
left a comment
There was a problem hiding this comment.
A couple of things that I noticed:
- A window resize will now permanently change the split ratio.
- A padding-only config reload doesn't update the minimum.
@jcollie Yep, that seemed like the simplest way to avoid strange behaviour but was a tradeoff
Can certainly fix the config aspect. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
That seems right. I'd also hook up notify::min-position in the same way as max-position. |
|
Config change update looks good. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@jcollie updated as requested. Renamed |
Fixes a regression of #1297 on GTK.
Issue
Splits can be dragged or resized down to 0px, which just looks like a thick divider. The 10px minimum from #1323 was lost in the GTK rewrite.
Fix
Splits are now at least one cell plus padding in size, and the divider can't be dragged past that. This also clamps keyboard resizes.
Tested on Fedora 44. Dragging and
resize_splitstop at one column or line. I believe that macOS already has its own minimum and is unchanged.First pass written with Claude Code (Claude Opus 5.5), reviewed and reprompted by me.