Repository navigation
terminal: fix reverse wrap cursor jump - #14390
Merged
Merged
Conversation
Stop when clearing pending wrap consumes the last cursor-left step. Otherwise, margin handling can move a restored cursor down to the top scrolling margin. Add a regression test that restores pending wrap at the left margin above the top scrolling margin. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
mitchellh
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With reverse wrapping enabled, a cursor-left (CUB) or Backspace after DECRC could jump the cursor down to the top of the scrolling region.
This happened when the restored cursor had pending wrap set and clearing it consumed the whole move, so the left-margin handling ran with nothing left to move. Stop once pending wrap is cleared and no move remains.
Reproduce:
This saves pending wrap, changes the margins, restores the cursor, then moves left and prints
X.ABon row 1;Xat row 3, column 2.AXon row 1.Tested with Kitty, which handles this correctly.
AI disclaimer: Created with gpt-6 astra using codex. Iterated on, reviewed and manually tested by me.