Repository navigation
gtk: avoid physical fallback for XKB modifiers - #13967
Merged
jcollie merged 1 commit intoAug 22, 2026
Merged
Conversation
Contributor
|
Hi @tothedarktowercame, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
pluiedev
approved these changes
Aug 22, 2026
pluiedev
left a comment
pluiedev
left a comment
Member
There was a problem hiding this comment.
Separating out remapKey is also a good idea. Thanks!
jcollie
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that this XKB config line was causing problems for Ghosttty:
That's a valid reconfiguration of the "delete key" as a modifier, and the same worked fine in other terminal emulators (like Alacritty). With Ghosttty, I was getting actual
<delete>behaviour whenever I pressed the modifier key (although the modifier engaged after that).This patch fixes it. In line with your AI disclose policy: I made the patch with Codex Sol. The logical fix is very succinct, and the bulk of the patch works around an underlying issue to do with GDK not recognising some modifiers as modifiers. I've tested the implementation and the patch definitely resolves it!