Repository navigation
terminal/kitty: fix various validation behaviors to match Kitty - #13933
Merged
Merged
Conversation
There are various validation behaviors we did that matched the spec but didn't match Kitty, because Kitty is written in C (these parts) and does a lot of C-ish things (like bool is any non-zero value, despite the spec saying 1/0). This also fixes a more major issue where invalid formats should be deferred until transmission finishes so we send a proper response. Right now we send no response which can cause a client to hang!
mitchellh
force-pushed
the
kitty-validate
branch
from
August 20, 2026 16:24
db9007d to
2427232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are various validation behaviors we did that matched the spec but didn't match Kitty, because Kitty is written in C (these parts) and does a lot of C-ish things (like bool is any non-zero value, despite the spec saying 1/0).
This also fixes a more major issue where invalid formats should be deferred until transmission finishes so we send a proper response. Right now we send no response which can cause a client to hang!