Repository navigation
terminal/kitty: preserve chunked response identifiers - #13897
Merged
Merged
Conversation
Chunked image responses used the final command even though only the initial chunk carries the image and placement identifiers. Successful replies lost image numbers and placement IDs. Final validation errors could also be suppressed entirely. Save the initial response identifiers with the in-progress image and use them when the final chunk completes. Continue replacing the response ID with the generated image ID after a successful load. Cover successful image-number replies and invalid final payloads with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunked image responses used the final command even though only the initial chunk carries the image and placement identifiers. Successful replies lost image numbers and placement IDs. Final validation errors could also be suppressed entirely.
Save the initial response identifiers with the in-progress image and use them when the final chunk completes. Continue replacing the response ID with the generated image ID after a successful load. Cover successful image-number replies and invalid final payloads with unit tests.