Repository navigation
feat: expand tildes in config theme path to HOME - #13840
Merged
jcollie merged 4 commits intoAug 16, 2026
Merged
Conversation
When loading a theme from a path that includes a tilde: ``` theme="~/.cache/wal/colors-ghostty" ``` currently fails with the following error: ``` cannot include path separators unless it is an absolute path ``` This PR tries to expand the ~ of the path. If there is no ~ or expansion fails, it falls back to the unexpanded value.
Contributor
|
Hi @preiter93, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
jcollie
requested changes
Aug 15, 2026
jcollie
left a comment
jcollie
left a comment
Member
There was a problem hiding this comment.
Tilde expansion should happen when the config is parsed, not when the theme is loaded.
preiter93
force-pushed
the
pr/expand-tildes-in-config-theme
branch
from
August 15, 2026 18:08
5c24607 to
b5dc6e9
Compare
preiter93
force-pushed
the
pr/expand-tildes-in-config-theme
branch
from
August 15, 2026 18:10
b5dc6e9 to
c121734
Compare
jcollie
requested changes
Aug 15, 2026
Member
|
This is looking good, just need to fix up the formatting to please |
Contributor
Author
|
done, feel free to merge when it goes through ci :) |
jcollie
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a theme from a path that includes a tilde:
ghostty currently fails with the following error:
This PR tries to expand the ~ of the path. If there is no ~ or expansion fails, it falls back to the unexpanded value.