Repository navigation
terminal: avoid VS15 cursor underflow - #13631
Merged
Merged
Conversation
Handle VS15 width changes when the wide grapheme base is directly under the cursor. Cover both disabled wraparound and restored pending-wrap cursor states. A zero cursor distance previously underflowed while locating the spacer tail. Debug builds panicked and ReleaseFast computed an out-of-bounds cell pointer before updating it. Find the spacer from the wide base instead of subtracting from the cursor distance. Reposition the cursor from the base column and clamp it to the active right margin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle VS15 width changes when the wide grapheme base is directly under the cursor.
A zero cursor distance previously underflowed while locating the spacer tail. Debug builds panicked and ReleaseFast computed an out-of-bounds cell pointer before updating it.