Repository navigation
terminal: handle page capacity errors in cursorScrollAbove - #13394
Merged
Merged
Conversation
Re: #13160 When cursorScrollAbove rotates rows across a page boundary, the last row of the previous page is cloned into the destination page. That can cause capacity failures we didn't previously handle. The error propagated out of the operation after rows had already been rotated, leaving the page list half-mutated. Subsequent operations on the corrupted state can cause crashes since the state was incoherent. Handle these errors the same way insertLines and deleteLines already do for their cross-page copies: increase the destination page capacity for the dimension that ran out and retry the row copy.
Contributor
Author
|
FYI I think |
This was referenced Jul 20, 2026
neurosnap
added a commit
to neurosnap/zmx
that referenced
this pull request
Jul 21, 2026
This updates libghostty which fixes a SIGABRT from hyperlink rendering. Closes: #182 Reference: ghostty-org/ghostty#13394
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #13160
When cursorScrollAbove rotates rows across a page boundary, the last row of the previous page is cloned into the destination page. That can cause capacity failures we didn't previously handle.
The error propagated out of the operation after rows had already been rotated, leaving the page list half-mutated. Subsequent operations on the corrupted state can cause crashes since the state was incoherent.
Handle these errors the same way insertLines and deleteLines already do for their cross-page copies: increase the destination page capacity for the dimension that ran out and retry the row copy.