Repository navigation
terminal/search: reset cached results after resize - #13274
Merged
Merged
Conversation
Screen searches only reset cached dimensions while feeding more history. Selecting or reloading a result immediately after a resize left flattened highlights pointing at page nodes freed by reflow. The next selection operation could dereference those stale pointers and crash. Centralize dimension invalidation and run it before feed, reload, and selection paths inspect cached state. Add regression coverage for selecting a cached active match after a column resize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen searches only reset cached dimensions while feeding more history. Selecting or reloading a result immediately after a resize left flattened highlights pointing at page nodes freed by reflow. The next selection operation could dereference those stale pointers and crash.
Centralize dimension invalidation and run it before feed, reload, and selection paths inspect cached state. Add regression coverage for selecting a cached active match after a column resize.