Repository navigation
renderer: avoid allocating when there are no active links - #13258
Merged
Merged
Conversation
Determine if any links are active before building the string and byte-to-cell map. Those buffers scale with viewport size, and this function runs during frame updates, so avoid allocating them when the current mouse/modifier state can't highlight any regex links. This adds an additional `self.links` iteration, but that list is usually small, the "active" check is cheap, and it breaks on the first hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine if any links are active before building the string and byte-to-cell map. Those buffers scale with viewport size, and this function runs during frame updates, so avoid allocating them when the current mouse/modifier state can't highlight any regex links.
This adds an additional
self.linksiteration, but that list is usually small, the "active" check is cheap, and it breaks on the first hit.GPT 5.5 spotted this and wrote the test case. I came up with the tradeoffs myself and wrote the runtime code.