Repository navigation
terminal: hook up glyph protocol glossary to terminal state - #12937
Merged
Merged
Conversation
This hooks up the glyph protocol glossary to the terminal state. This effectively makes us handle the APC protocol for it both in Ghostty GUI and libghostty, although we didn't implement the renderer yet. The Zig/C libghostty API also has a way to disable the protocol but it is enabled by default. The memory usage is bound by the specification. For dirty tracking for the renderer, we're going with the simple route that any glyph change marks a coarse grained dirty flag and we'll [in the future] rebuild the entire state in the renderer. I think this will be fine for realistic workloads, but we can reassess in the future when we have real workloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hooks up the glyph protocol glossary to the terminal state. This effectively makes us handle the APC protocol for it both in Ghostty GUI and libghostty, although we didn't implement the renderer yet.
The Zig/C libghostty API also has a way to disable the protocol but it is enabled by default. The memory usage is bound by the specification.
For dirty tracking for the renderer, we're going with the simple route that any glyph change marks a coarse grained dirty flag and we'll [in the future] rebuild the entire state in the renderer. I think this will be fine for realistic workloads, but we can reassess in the future when we have real workloads.