Repository navigation
deal with large outputs from xdg-open/rundll32/open - #12797
Merged
Merged
Conversation
Depending on your system config, `xdg-open` may stay open for extended periods, and potentially log more than the 50kb of output that we were previously able to deal with. This changes `open()` so that output on `stdout` is just directly ignored. Any output from `stderr` is immedialy logged rather than collected for later logging. Note that this will generally occur if your system is not configured with the DBus portals that `xdg-open` uses to open URLs rather than launching programs like your web browser directly. This could be seen as user misconfiguration but we should deal with it robustly anyway.
mitchellh
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on your system config,
xdg-openmay stay open for extended periods, and potentially log more than the 50kb of output that we were previously able to deal with. This changesopen()so that output onstdoutis just directly ignored. Any output fromstderris immedialy logged rather than collected for later logging.Note that this will generally occur if your system is not configured with the DBus portals that
xdg-openuses to open URLs rather than launching programs like your web browser directly. This could be seen as user misconfiguration but we should deal with it robustly anyway.