Repository navigation
Fix zero-width grapheme attachment during pending wrap - #12581
Merged
Merged
Conversation
mitchellh
requested changes
May 4, 2026
mitchellh
left a comment
mitchellh
left a comment
Contributor
There was a problem hiding this comment.
This makes sense, we should add a test to Terminal.zig too though that's the more appropriate place for this since the C tests are only run conditionally. You can keep that C test too though.
noib3
force-pushed
the
zero-width-attachments
branch
from
May 4, 2026 21:12
15cf1d7 to
04e8824
Compare
Contributor
Author
|
Added an equivalent test to Terminal.zig. Not sure what the policy is wrt to test redundancy. I can remove the test in |
This PR fixes an issue where a zero-width combining mark could attach to the wrong cell when the preceding character was written in the final column and the cursor had a pending wrap.
noib3
force-pushed
the
zero-width-attachments
branch
from
May 4, 2026 21:16
04e8824 to
c20fcfa
Compare
mitchellh
approved these changes
May 4, 2026
mitchellh
left a comment
mitchellh
left a comment
Contributor
There was a problem hiding this comment.
Approved pending CI.
General note: print is one of our most performance sensitive pieces of code, but this is specifically in the width == 0 branch which is not common, so adding more logic here is fine.
Not sure what the policy is wrt to test redundancy. I can remove the test in c/terminal.zig since that code path is now already covered.
Its fine, I don't mind duplicate tests that test at different layers.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
May 4, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
May 5, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
May 12, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
May 13, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
5 tasks done
noib3
added a commit
to noib3/neovim
that referenced
this pull request
May 18, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
May 22, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
Jun 4, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
Jul 12, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
Jul 23, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
noib3
added a commit
to noib3/neovim
that referenced
this pull request
Jul 25, 2026
We need the fix I implemented in ghostty-org/ghostty#12581 for our tests to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a zero-width combining mark could attach to the wrong cell when the preceding character was written in the final column and the cursor had a pending wrap.
The test I added used to fail before the fix, but it passes now.