Repository navigation
macOS: fix focus state when toggling command palette from inline title editor - #12524
Merged
Merged
Conversation
mitchellh
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug found while recording that menu fix.
When toggling the command palette from the inline title editor, the first responder state of the surface is changed quickly from true to false.
makeFirstResponder:is called by the title editor when finishing, but it happens after the command palette is shown, so thefocusedis set totruewhile the command palette is shown. (Could be an AppKit issue as well, since the resign is not called after but the command palette is receivingkeyDown.)Since
performKeyEquivalent(with:)is called on all of the subviews until one of the returntrueso the paste action is consumed by the surface instead of the first responder (command palette).