Skip to content

Fix Korean IME committed text handling for arrow keys - #12447

Merged
mitchellh merged 1 commit into
ghostty-org:mainfrom
dobbylee:fix-korean-ime-arrow-commit
Apr 25, 2026
Merged

mitchellh merged 1 commit into
ghostty-org:mainfrom
dobbylee:fix-korean-ime-arrow-commit

Conversation

@dobbylee

Copy link
Copy Markdown
Member

Fixes #11461

  • Send Korean IME committed text as a separate text-only key event when arrow-key handling commits preedit text.
  • Replay arrow navigation after the committed text is sent. Do not replay plain Left Arrow to match Terminal.app behavior.
  • Manually tested Arrow keys and Opt/Cmd+Arrow during Korean preedit on macOS.

@dobbylee
dobbylee requested a review from a team as a code owner April 25, 2026 16:33
@mitchellh mitchellh added this to the 1.4.0 milestone Apr 25, 2026

@mitchellh mitchellh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty hacky but willing to accept it because its VERY tightly scoped and the conditional is based on unlikely factors so its unlikely to affect input latency. Approved pending CI.

@mitchellh
mitchellh merged commit df4f981 into ghostty-org:main Apr 25, 2026
90 checks passed
@dobbylee
dobbylee deleted the fix-korean-ime-arrow-commit branch April 25, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: Korean IME preedit cancelled (not committed) when pressing arrow keys

2 participants