Repository navigation
macOS: fix command parsing in NewTerminalIntent - #12392
Merged
Merged
Conversation
Fixes ghostty-org#12391, regression from ghostty-org#10765 Signed-off-by: Lukas <134181853+bo2themax@users.noreply.github.com>
bo2themax
force-pushed
the
siri-shortcut
branch
from
April 23, 2026 09:35
4da3062 to
a8ed37a
Compare
calebhearth
added a commit
to calebhearth/dotfiles
that referenced
this pull request
Sep 18, 2026
Ghostty 1.3 quotes the New Terminal intent's Command as a single shell word before typing it into the login shell (Ghostty commit 1ff0dd8, "macos: quote input strings used for shell commands", 2026-02-05). The handler wrote the whole vim-dispatch wrapper line into the shortcut's input file, so the shell saw one giant token, printed "command not found", and exited. None of dispatch's temp files (`.pid`, `.complete`, the output file) were written, so `:Copen` stayed empty. Upstream reverted the quoting in April, but no tagged release has it yet. Write the wrapper to an executable script at `<file>.dispatch` and hand the shortcut only that path. A temp path has no shell-unsafe characters, so it survives the quoting and also works once Ghostty ships the fix. The shortcut itself is unchanged. Also fix the start branch, which concatenated an undefined `command` variable and threw E121 on every `:Start`, and drop the debug `echo`, the unused `--output-path` file, and the `&shellredir` suffix left over from the kitty handler. Add a headless nvim regression test and a `make test` target. The `g:dispatch_ghostty_launcher` variable exists so the test can capture the input file instead of calling Shortcuts. Related-to: ghostty-org/ghostty#12391 Related-to: ghostty-org/ghostty#12392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12391, regression from #10765