Skip to content

macos: add support for middle-click tab close for macos-titlebar-style = tabs - #11963

Merged
mitchellh merged 1 commit into
ghostty-org:mainfrom
nicholas-ochoa:add-middle-click-tab-close
Mar 29, 2026
Merged

mitchellh merged 1 commit into
ghostty-org:mainfrom
nicholas-ochoa:add-middle-click-tab-close

Conversation

@nicholas-ochoa

@nicholas-ochoa nicholas-ochoa commented Mar 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #11962

Summary

This PR implements a fix for: #10264

This allows the macos-titlebar-style setting tabs to behave the same way other titlebar style options do with middle click handling.

AI Disclosure

I used claude code (Sonnet 4.6) to identify the best place to start when implementing this change, as well as for general Swift questions. The code within this PR is written by me.

@nicholas-ochoa
nicholas-ochoa requested a review from a team as a code owner March 29, 2026 20:39
@ghostty-bot ghostty-bot Bot added the os/macos label Mar 29, 2026
@jcollie jcollie linked an issue Mar 29, 2026 that may be closed by this pull request
@jcollie jcollie added this to the 1.4.0 milestone Mar 29, 2026
@mitchellh
mitchellh force-pushed the add-middle-click-tab-close branch from 3cb48a8 to 3f6683d Compare March 29, 2026 22:19
@mitchellh
mitchellh merged commit 5540f5f into ghostty-org:main Mar 29, 2026
81 checks passed
bo2themax added a commit to bo2themax/ghostty that referenced this pull request Mar 30, 2026
…ebar-style = tabs` (ghostty-org#11963)"

This reverts commit 5540f5f, reversing
changes made to cca4c78.
@nicholas-ochoa
nicholas-ochoa deleted the add-middle-click-tab-close branch April 3, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Middle clicking on tab on macOS should close it

3 participants