Repository navigation
bash: suppress __ghostty_hook errors in inherited PROMPT_COMMAND - #11690
Merged
Merged
Conversation
When some tools spawn subshells, PROMPT_COMMAND may be inherited as an environment variable while the __ghostty_hook function is not (bash doesn't export functions by default). This causes "command not found" errors on every prompt in the subshell. Add 2>/dev/null to the __ghostty_hook entry in PROMPT_COMMAND so that it silently no-ops in subshells where the function isn't defined. This also silences any errors from inside __ghostty_hook itself, but those are all terminal escape sequences and non-actionable. See: ghostty-org#11245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When some tools spawn subshells, PROMPT_COMMAND may be inherited as an environment variable while the __ghostty_hook function is not (bash doesn't export functions by default). This causes "command not found" errors on every prompt in the subshell.
Add 2>/dev/null to the __ghostty_hook entry in PROMPT_COMMAND so that it silently no-ops in subshells where the function isn't defined. This also silences any errors from inside __ghostty_hook itself, but those are all terminal escape sequences and non-actionable.
See: #11245