[EriksRemess]

Most obvious next step in translating Ghostty is the command palette.
Added support for i18n.N_ (https://docs.gtk.org/glib/i18n.html#macros).
Made a Latvian translation for the command palette to test. Codex did bulk of the translations but I verified them.

[mitchellh]

I definitely want more reviewers, but this in general makes sense. I made one note.

[00-kat]

It would be nice if Latvian translation updates were done in a separate future PR, since that requires a review from a completely different set of people as the rest of the code and is orthogonal to this PR.

[00-kat]

Also, I'm not sure how it's done but I believe you need to update all the other translation files to have the untranslated strings placed in them; other PRs that added translations (e.g. #9976) have done so.

[EriksRemess]

Ok, I'll remove Latvian translation for now. Should I also remove .pot? That is also generated by the same zig build update-translations.

[00-kat]

Definitely keep the .pot changes, having empty strings for the translations is fine; reviewing the translated text themselves is what's problematic (since most maintainers can't review that, so we need to ping the respective localization team).

[00-kat]

I believe you need to update all the other translation files to have the untranslated strings placed in them

zig build update-translations

It looks like update-translations itself should do that:

ghostty/src/build/GhosttyI18n.zig

Lines 185 to 190 in c2e9de2

	inline for (locales) |locale| {
	const msgmerge = b.addSystemCommand(&.{ "msgmerge", "--quiet", "--no-fuzzy-matching" });
	msgmerge.addFileArg(b.path("po/" ++ locale ++ ".po"));
	msgmerge.addFileArg(xgettext_merge.captureStdOut());
	usf.addCopyFileToSource(msgmerge.captureStdOut(), "po/" ++ locale ++ ".po");
	}

If it changed every single translation file to add untranslated strings, you should probably git add that.

[EriksRemess]

I guess, test should be retried https://github.com/ghostty-org/ghostty/actions/runs/23306874737/job/67784178019?pr=11641

[00-kat]

Thanks!

test should be retried

Done.

[trag1c]

@EriksRemess Could you rebase? We're looking to merge this before the v1.4 string freeze :)

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[clason]

Is this something that can be controlled? Because I don't want to be at the mercy of my locale for the command palette muscle memory...

(To be clear, my UI language is set to English, different from the locale. So now the command palette and nothing else is in a different -- undesired -- language...)

[jcollie]

Is this something that can be controlled? Because I don't want to be at the mercy of my locale for the command palette muscle memory...

Controlled how? Are you searching for a specific English word in the command palette that wouldn't be there if the command palette was localized?

[clason]

This is how it looks like. u is now a shortcut for "quit", not "update". I would like to force everything to English, at pretty much any cost.

[jcollie]

This is how it looks like. u is now a shortcut for "quit", not "update". I would like to force everything to English, at pretty much any cost.

Set language = en in your config and it will force Ghostty (and only Ghostty) to use English.

[clason]

But I am already forcing everything at system level to English, which Ghostty doesn't (fully) respect...

(Sorry, I should make clear that this is on macOS, where interface language and other locale (e.g., date or currency) settings can be set independently. Platform matters here, of course.)

[00-kat]

Force everything in Ghostty? https://ghostty.org/docs/config/reference#language

It's not currently possible to only change it for the command palette though.

Edit:

which Ghostty doesn't (fully) respect

That sounds wrong though… maybe it might be worth opening a discussion on that if you care to.

[jcollie]

(Sorry, I should make clear that this is on macOS. Platform matters here, of course.)

Oh, ah, hm. That does appear to be a regression. We haven't formally started translating the macOS app. The command palette is the first crossplatform code that has had translation added and seems we need to figure that out.

[clason]

Set language = en in your config and it will force Ghostty (and only Ghostty) to use English.

Sorry, but that makes no difference.

[jcollie]

Set language = en in your config and it will force Ghostty (and only Ghostty) to use English.

Sorry, but that makes no difference.

Yeah, that's really a GTK-only config.

[clason]

So maybe this feature can be made GTK-only for now?

[jcollie]

So maybe this feature can be made GTK-only for now?

We'll need to figure out the best way to handle this. Not sure what the best solution will be.