Repository navigation
gtk/wayland: refactor global handling - #11559
Merged
Merged
Conversation
Member
Author
|
@jguthmiller Could you try and see if this PR kept the changes you introduced in #11117? I don't have a KDE test setup and I wanna be sure I didn't accidentally introduce any regressions :) |
mitchellh
requested changes
Mar 16, 2026
The way we originally handled globals gradually escalated into an unholy mess of ad-hoc helper functions and special-case handlers, which proved to be hard to scale. Using a type-erased EnumMap like this makes everything *far* easier to work and reason with, I think. Also nuked the `xdg_wm_dialog_v1` hack that was necessary to prevent old versions of gtk4-layer-shell crashing. If by the time of 1.4's release people are still using those versions, it's on them.
pluiedev
force-pushed
the
pluie/jj-wlztolkqxlmz
branch
from
March 16, 2026 17:15
d2fb60a to
8966d37
Compare
mitchellh
approved these changes
Mar 16, 2026
mitchellh
left a comment
mitchellh
left a comment
Contributor
There was a problem hiding this comment.
Approved, I didn't test it so just trusting you.
Member
Author
|
Yeah it works for me for basic things but I'm waiting for @jguthmiller to verify if I broke anything since that's were most of the complexity lies :) |
Contributor
|
@pluiedev Looks good! All of the quick terminal screen options behave as expected. |
Member
Author
|
Excellent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we originally handled globals gradually escalated into an unholy mess of ad-hoc helper functions and special-case handlers, which proved to be hard to scale. Using a type-erased EnumMap like this makes everything far easier to work and reason with, I think.
Also nuked the
xdg_wm_dialog_v1hack that was necessary to prevent old versions of gtk4-layer-shell crashing. If by the time of 1.4's release people are still using those versions, it's on them.