Repository navigation
config: add equal option to window-padding-balance - #11491
Conversation
|
Hi @devsunb, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
|
!vouch |
Triggered by [comment](#11491 (comment)) from @mitchellh. Vouch: @devsunb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@mitchellh Thank you. I was writing a Vouch Request after reading the Contributing Guide late. I ran into image rendering issues with snacks.nvim inside tmux because WezTerm’s Kitty Image Protocol support does not currently support unicode placeholders. I first explored fixing this in WezTerm, but since I needed a solution sooner, I also began evaluating Ghostty, which is under active development. To match my WezTerm setup more closely in Ghostty, I needed two things: even padding support, which this PR implements and which is similar to WezTerm’s window_content_alignment option, and FreeType font rasterization, which currently seems to require a manual build using I have read and agree with the AI Policy. Claude Code assisted me in understanding the codebase and generating code, but I have reviewed and understood all text and code included in this PR. |
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Perfect except for one note.
Change `window-padding-balance` from `bool` to an enum with three values: - `false` - no balancing (default, unchanged) - `true` - balance with vshift that caps top padding and shifts excess to bottom (existing behavior, unchanged) - `equal` - balance whitespace equally on all four sides This gives users who prefer truly equal padding a way to opt in without changing the default behavior.
90bc422 to
86d9a04
Compare
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Perfect except for one note.
Triggered by [comment](ghostty-org/ghostty#11491 (comment)) from @mitchellh. Vouch: @devsunb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Change
window-padding-balancefromboolto an enum with three values:false- no balancing (default, unchanged)true- balance with vshift that caps top padding and shifts excess to bottom (existing behavior, unchanged)equal- balance whitespace equally on all four sidesThis gives users who prefer truly equal padding a way to opt in without changing the default behavior.