Repository navigation
Conversation
pluiedev
requested changes
Jan 27, 2026
pluiedev
left a comment
pluiedev
left a comment
Member
There was a problem hiding this comment.
First round of reviews, definitely not exhaustive since there's a ton to go through
jcollie
force-pushed
the
osc-kitty-notifications
branch
2 times, most recently
from
January 29, 2026 20:50
c726052 to
ffaf0c2
Compare
pluiedev
requested changes
Feb 1, 2026
jcollie
force-pushed
the
osc-kitty-notifications
branch
from
February 1, 2026 19:39
ffaf0c2 to
8ae4dd9
Compare
pluiedev
approved these changes
Feb 14, 2026
jcollie
force-pushed
the
osc-kitty-notifications
branch
from
February 16, 2026 23:14
8ae4dd9 to
d412b3c
Compare
This was referenced Feb 17, 2026
joelmoss
added a commit
to joelmoss/workroom
that referenced
this pull request
Jun 5, 2026
Checked ghostty 'main' (the dev tip, not just the 1.2.3 release): there's no OSC-99 parser today, but OSC 99 support is an OPEN upstream PR (ghostty-org/ghostty#10467, 'parse the Kitty desktop notification protocol'). So it's coming, not a permanent non-feature. Update QA §H + the xcframework re-verify note: build the xcframework from a ghostty ref that includes #10467 (or cherry-pick it) to restore OSC 99; ghostty's in-progress libghostty fallback-handler for unknown OSC is an alternate app-side path. OSC 9/777 cover the common cases meanwhile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Would like to use this! Is it ready to go still? |
Member
Author
Other than a rebase I think that this is still ready to go. |
jcollie
force-pushed
the
osc-kitty-notifications
branch
from
June 11, 2026 04:35
8034b93 to
a591987
Compare
Member
Author
|
Pushed a rebase. |
This includes only parsing of the OSC. You cannot use OSC 99 to send notifications. Uses lazy parsing of the metadata modelled on the new OSC 133 behavior.
* Add comments to Option keys to clarify their usage without having to refer to the spec online. * Use `indexOfNone` to simplify code.
* Fix typos. * Eliminate metadata parsing code duplication. * Improve documentation. * Ensure assert is comptime only. * Derive valid metadata characters from valid identifier characters.
Reduce redundant code by sharing the metadata parsing code between the OSC 99 & OSC 5522 parsers.
jcollie
force-pushed
the
osc-kitty-notifications
branch
from
August 1, 2026 15:38
a591987 to
c08f965
Compare
Contributor
|
Merged! Sorry did local review so couldn't go through PR, but authorship retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes only parsing of the OSC. You cannot (yet) use OSC 99 to send notifications. Uses lazy parsing of the metadata modelled on the new OSC 133 behavior.
Related to #5634