Skip to content

Apply cxx_flags to Windows module actions - #912

Closed
PikachuHyA wants to merge 1 commit into
bazelbuild:mainfrom
PikachuHyA:msvc_support
Closed

PikachuHyA wants to merge 1 commit into
bazelbuild:mainfrom
PikachuHyA:msvc_support

Conversation

@PikachuHyA

Copy link
Copy Markdown
Contributor

No description provided.

@PikachuHyA PikachuHyA changed the title Apply C++ flags to Windows module actions Apply cxx_flags to Windows module actions Sep 29, 2026
@PikachuHyA

Copy link
Copy Markdown
Contributor Author

this pr add missing cxx_flags config.

We could also consider switching to use all_cpp_compile_actions for other config to avoid this kind of issue.

Note: The Windows CI failure seems unrelated to my changes.

cc @trybka @fmeum

@PikachuHyA

Copy link
Copy Markdown
Contributor Author

@trybka ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants