Repository navigation
Conversation
rules_python switched to using --enable_runfiles on windows which revealed a bug that we weren't copying dependent dylibs for cc_shared_library as we do for cc_binary.
keith
marked this pull request as ready for review
September 25, 2026 18:30
fmeum
approved these changes
Sep 25, 2026
UebelAndre
reviewed
Sep 27, 2026
Co-authored-by: UebelAndre <github@uebelandre.com>
trybka
self-requested a review
September 28, 2026 19:42
trybka
previously approved these changes
Sep 28, 2026
keith
force-pushed
the
ks/fix-cc_shared_library-locations-with-rules_python-on-windows
branch
from
September 28, 2026 21:45
312a737 to
a91965c
Compare
Member
Author
|
ok it seems like that permissions zip thing was because the zip file came from the cache, and this has been fixed in rules_python 2.0+ by removing that feature all together. green again |
keith
force-pushed
the
ks/fix-cc_shared_library-locations-with-rules_python-on-windows
branch
from
September 29, 2026 01:13
2507296 to
40b44b6
Compare
UebelAndre
reviewed
Sep 29, 2026
trybka
approved these changes
Sep 29, 2026
Collaborator
|
so this merged and there is a different permissions error? |
keith
deleted the
ks/fix-cc_shared_library-locations-with-rules_python-on-windows
branch
November 16, 2026 23:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_python switched to using --enable_runfiles on windows which
revealed a bug that we weren't copying dependent dylibs for
cc_shared_library as we do for cc_binary.