Skip to content

Honor object extensions for ThinLTO merged artifacts - #853

Closed
cerisier wants to merge 2 commits into
bazelbuild:mainfrom
cerisier:cerisier/thinlto-merged-object-extension
Closed

cerisier wants to merge 2 commits into
bazelbuild:mainfrom
cerisier:cerisier/thinlto-merged-object-extension

Conversation

@cerisier

Copy link
Copy Markdown
Contributor

The ThinLTO merged object is hard-coded with an .o suffix even when the toolchain configures .obj for object files. This leaves clang-cl/MSVC action graphs with .obj compilation outputs but a .o indexing output and final-link input.

Derive the merged artifact suffix from the toolchain's OBJECT_FILE artifact category. Unix toolchains keep the default .o. Focused analysis coverage configures .obj and checks both the indexing output and final-link input.

@cerisier
cerisier marked this pull request as ready for review August 21, 2026 12:28

@trybka trybka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good for now, but if we envision wanting to change other file extensions for testing, a cleaner interface for injection might be warranted.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants