Repository navigation
Conversation
cerisier
marked this pull request as ready for review
August 21, 2026 12:28
fmeum
approved these changes
Aug 21, 2026
trybka
approved these changes
Aug 21, 2026
trybka
left a comment
Collaborator
There was a problem hiding this comment.
This seems good for now, but if we envision wanting to change other file extensions for testing, a cleaner interface for injection might be warranted.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ThinLTO merged object is hard-coded with an
.osuffix even when the toolchain configures.objfor object files. This leaves clang-cl/MSVC action graphs with.objcompilation outputs but a.oindexing output and final-link input.Derive the merged artifact suffix from the toolchain's
OBJECT_FILEartifact category. Unix toolchains keep the default.o. Focused analysis coverage configures.objand checks both the indexing output and final-link input.