Repository navigation
Conversation
b3c694e to
de3c616
Compare
de3c616 to
3f7280c
Compare
|
In general instead of using this one you should add this to your .bazelrc: Ideally we would add this to this ruleset, but it wouldn't work with older versions of clang. |
@keith do you know when this was added to clang? We could add conditionally add the flag based on the clang version right? |
|
looks like as far back as 13.x. im not sure if anything in these rules are doing that now, but yea ideally |
Should we just add it as soon as we detect a newer version then? |
|
fwiw for newer clang versions |
This PR aims to make artifacts built with
toolchains_llvmmore reproducible by specifying:in the compile and linker flags. Then in
cc_wrapper.shwe replace${{pwd}}with the current absolute path the script is being invoked from. This should result in builds being more reproducible by replacing absolute local paths in the binary with__bazel_toolchain_llvm_repo__.For example, today in the MaterializeInc/materialize repo, building the
@bzip2//:bzip2target and runningstringson the final binary, I get several results like this:After this PR all said entries are replaced with:
@keith I see in #440 you removed the use of
-fdebug-prefix-path, I'm curious what you think of this since it not only effects debug info but also pre-processor macros.