Repository navigation
fix: bugs with rdflib.extras.infixowl - #2390
Merged
aucampia merged 25 commits intoMay 19, 2023
Merged
Conversation
tidy `# docstring` syntax and replace antiquated namespace_manager bindings with moderm graph ns bindings.
`subject_node_closure` and `blank_node_closure` don't have tests and are not essential to the rest of the PR. Removing them so the rest can be merged.
Removing this would be a breaking change, it should be marked as deprecated instead and if it is being replaced by another function then it should call the other function.
This will invalidate the xfail if the exception being raised changes, which makes it a bit safer to use xfail, as it is less likely to mask other newly introduced bugs.
Member
Author
|
@gjhiggins please see if you are okay with the changes I made. All changes can be seen here: Of particular import may be:
|
aucampia
commented
May 19, 2023
As far as I know this is not a documented dunder, and according to PEP-8 \[[ref](https://peps.python.org/pep-0008/#descriptive-naming-styles)\]: > Never invent such names; only use them as documented.
aucampia
force-pushed
the
aucampia/20230519T1021-infix-fixes
branch
from
May 19, 2023 10:05
f99f085 to
e65e721
Compare
aucampia
added
the
ready to merge
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix the following issues in
rdflib.extras.infixowl:manchesterSyntaxwas wrong for some cases.BooleanClasswas generating its string representation (i.e.BooleanClass.__repr__) was wrong for some cases.Other changes:
This code is based on code from:
Checklist
the same change.
./examplesfor new features.so maintainers can fix minor issues and keep your PR up to date.