Repository navigation
Conversation
Contributor
|
Tested, fixes #3321, thanks! It looks fine to me but I can't really review the code. If it's acceptable to the rest of the devs I think this should go into stable-1.2 . Welcome to the lmms but tracker... :) |
jasp00
reviewed
Dec 23, 2018
jasp00
left a comment
jasp00
left a comment
Member
There was a problem hiding this comment.
Code looks good. It should go into stable-1.2.
Member
|
It looks fine to me, though I think we may also fix this on a different side. |
Contributor
@PhysSong Can you want to be more specific? I would like to push this to stable-1.2 tomorrow if there are no bigger objections. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first contribution, so please tell me if I do something wrong.
I hope many will follow ;)