Repository navigation
Put the chart menu at the view's top right; ask where a download goes - #477
Conversation
A chart's ⋯ menu sat on the figure's axes where hover left it unreadable. The button now lives at the card header's right edge, shows while the card is hovered, focused or open, and stays on touch screens; each chart hands the card a handle so one menu serves every chart in the view, grouped and named after its caption. Fixes #476
A table switch rebuilt the chart's registration, so the card's Map moved the chart to the last group and its menu group took the next fallback name. The handle registers once at mount now and hands the menu the current label and table state through getters; a refreshCharts call on ctx redraws the card's menu without touching the order. Refs #476
Without a will-download listener the session saved files straight into the downloads folder with no sign of where they landed. The main window now asks with the system save dialog first; a cancelled dialog drops the download, and downloads started by any other contents keep their own rules.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3282b12dbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .bt-view-more svg{width:16px;height:16px} | ||
| .bt-menu.bt-view-menu{position:absolute;top:32px;right:0;--bt-origin:top right;min-width:180px} | ||
| .bt-menu.bt-view-menu button{gap:8px} | ||
| .bt-view-menu-label{padding:2px 8px;font-size:11px;line-height:14px;color:var(--bt-ink-3);white-space:nowrap} |
There was a problem hiding this comment.
Constrain long chart captions in the menu
When a valid chart has a long caption—the validator permits it to consume nearly the entire 8 KiB view—the non-wrapping label gives this absolutely positioned, right-anchored menu the caption's full width. Its left side, including the View/Copy/Download button content, can then extend off-screen and become inaccessible. Cap the menu or label to the viewport/card width and truncate or wrap the caption.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Note
Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| .bt-view-more svg{width:16px;height:16px} | ||
| .bt-menu.bt-view-menu{position:absolute;top:32px;right:0;--bt-origin:top right;min-width:180px} | ||
| .bt-menu.bt-view-menu button{gap:8px} | ||
| .bt-view-menu-label{padding:2px 8px;font-size:11px;line-height:14px;color:var(--bt-ink-3);white-space:nowrap} |
There was a problem hiding this comment.
🟡 Chart headings break the typography scale
For multiple charts, bt-view-menu-label uses 11px text with 14px line height. The UI standard requires 11px text to use 16px line height.
| .bt-view-menu-label{padding:2px 8px;font-size:11px;line-height:14px;color:var(--bt-ink-3);white-space:nowrap} | |
| .bt-view-menu-label{padding:2px 8px;font-size:11px;line-height:16px;color:var(--bt-ink-3);white-space:nowrap} |
Was this helpful? React with 👍 or 👎 to provide feedback.
Folded into this pull request so the release needs one CI round less.
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| - Chat bubbles widen with the window instead of stopping at a fixed width. ([#380](https://github.com/Fei2411/DeepSeek-Bot/issues/380), [#447](https://github.com/Fei2411/DeepSeek-Bot/pull/447)) | ||
| - A Bot's thinking is hidden by default; turn on **Show thinking** in Settings → General → Appearance to see it above the reply. Bot chats no longer show lines such as "Tools updated". ([#465](https://github.com/Fei2411/DeepSeek-Bot/issues/465), [#466](https://github.com/Fei2411/DeepSeek-Bot/pull/466)) | ||
| - Only one right panel opens at a time, and the Bot drawer has a New terminal button in place of the header's right-sidebar toggle. ([#456](https://github.com/Fei2411/DeepSeek-Bot/issues/456), [#470](https://github.com/Fei2411/DeepSeek-Bot/pull/470)) | ||
| - In the desktop app, a file you download from the window, such as a chart image, asks where to save it. ([#476](https://github.com/Fei2411/DeepSeek-Bot/issues/476), [#477](https://github.com/Fei2411/DeepSeek-Bot/pull/477)) |
There was a problem hiding this comment.
🟡 Premature release changelog entry
The download entry edits the released changelog, despite the repository rule reserving CHANGELOG.md edits for the maintainer's release PR.
| - In the desktop app, a file you download from the window, such as a chart image, asks where to save it. ([#476](https://github.com/Fei2411/DeepSeek-Bot/issues/476), [#477](https://github.com/Fei2411/DeepSeek-Bot/pull/477)) |
Was this helpful? React with 👍 or 👎 to provide feedback.





Issue
Fixes #476
What changed / 改了什么
Changelog
In the desktop app, a file you download from the window, such as a chart image, asks where to save it.
How I checked it / 怎么验证的
npm test(inds-bot/): 933 pass, 0 fail, 1 skip;app/tests with 3 new download casesnode scripts/build-client.mjs --checknpm run lint