Repository navigation
Bring the Bot activity row back on DSH 0.2.1 - #434
Conversation
The row looked for [data-chat-running] only as a direct child of [data-chat-flow]; when the shell wraps the slot the row never found a host and silently never drew. The search is now a descendant one, and without the slot the row falls back to the flow's tail. A page with no chat flow at all is a mount failure and is reported once through noteClientError. Relates to #349
A turn that streams its reply text first and calls a tool afterwards lost the activity row the moment text arrived: streaming hid the row unconditionally. The row now stays while the turn runs as long as no text is streaming or a tool is in flight; a group relay still hides it, since the group view shows members speaking on its own. Relates to #349
A Bot's sidebar row showed its last message while it worked in its own chat, so the preview looked idle during a turn. When the Bot is running and an activity is recorded, the row now previews it with the same workLine a group row uses; an idle Bot keeps the message preview. Fixes #349
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe9656d1a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const away = !running && groups.length > 0 | ||
| const state = botState(running || away, doing, alert) | ||
| // A Bot running in its own chat previews what it is doing, like a group's row. | ||
| const runningLine = running && doing ? doingLine(doing) : null |
There was a problem hiding this comment.
Whenever a Bot runs a tool that activityOf() classifies as searching—including web search, browser, and read tools—doing contains only the generic string searching. Passing that string to workPhrase() treats it as a tool name, matches the generic search pattern, and incorrectly displays “Looking through files…”. Use the structured work.bots[id] entry, which already contains the actual tool and target, for the own-chat preview while retaining activity for the avatar state.
AGENTS.md reference: AGENTS.md:L14-L15
Useful? React with 👍 / 👎.
Issue
Fixes #349
Bug: on DSH 0.2.1 the activity row under a Bot's chat (what it is doing, and for how long) never showed, and the sidebar showed no activity for a Bot working in its own chat.
What changed / 改了什么
Three commits, each can be reverted on its own:
[data-chat-running], so the row looks for it as a descendant and falls back to the flow's end; a page with no chat flow is reported once as a mount failure.Thanks to @Notoonex for the analysis in #349.
Changelog
The activity row under a Bot's chat and the sidebar preview show what a Bot is doing again on DSH 0.2.1.
How I checked it / 怎么验证的
npm test(inds-bot/): 844 pass, 0 fail, 1 platform skipnode scripts/build-client.mjs --checknpm run lint: 0 errorssrc/host/changeChecklist / 检查
src/client/changed →npm run buildran andclient.jsis committed. / 改了src/client/就已重新 build 并提交client.js。Co-authored-by. / 没有把 AI 工具写成作者或Co-authored-by。