Repository navigation
Let the Bot side panels reach the top edge under the caption buttons - #396
Conversation
Starting the panels below the title bar left a band of the conversation's color above them, beside caption buttons painted in the panel's color. In the desktop app the panels now reach the top edge with their content padded below the buttons, so the buttons stand on the panel's own surface; the band over the panel still drags the window. Where DSH's chrome top already clears the title bar the padding is 0.
|
The panel reaches the top edge; its buttons start below the 40px caption band.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c72752207
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The view that fades out during a details/browser switch is placed absolutely at the tabs' height, so with the band's padding it jumped up by the band.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…11#396 Fei2411#399 merged into fork
Issue
Fixes #389 (follow-up to #392)
What changed / 改了什么
#392 started the side panels below the title bar. That left a band of the conversation's color above the panel, next to caption buttons painted in the panel's color, which looked broken.
In a Windows title bar (not fullscreen)
.bt-panel/.bt-panenow keep their top and getpadding-top= title bar height − chrome top. In the desktop app (chrome top 0) the panel reaches the top edge, its content starts below the buttons, and the buttons stand on the panel's own surface: the app's caption color sampler already paints the layers at the top-right point over the column color, so the buttons take the panel's color.A
::beforeband of the same height keeps dragging the window over the panel.In DSH Desktop (chrome top = title bar height) the padding is 0, so nothing changes there; fullscreen, DSH Web and macOS are unchanged.
桌面应用里侧面板顶到窗口最上沿，内容从系统按钮下方开始，按钮落在面板自己的底色上；面板上方那条仍可拖动窗口。DSH Desktop 里不变。
Changelog
The Bot details panel reaches the top of the window on Windows, under the window buttons, without a band of another color.
How I checked it / 怎么验证的
npm test(inds-bot/): 797 tests, 796 pass, 1 skipped (existing Windows skip).node scripts/build-client.mjs --checknpm run lint: 0 errors, same warnings asdev.padding-top40px, its::before40px high with-webkit-app-region: drag, the panel is among the elements under the caption point (so the buttons take its color, rgb(252,252,252)), its buttons at 52px. Withdata-fullscreen: padding 0, buttons at 12px. Screenshot below. Dark theme not checked by eye; the panel color and the sampled caption color come from the same element.Checklist / 检查
src/client/changed →npm run buildran andclient.jsis committed.Co-authored-by.