Repository navigation
Guide ordinary sessions after a rejected Bot question tool call - #368
Merged
Merged
Conversation
When a non-Bot session attempts ask_user, explain how to continue with the standard question tool if it is available or with a plain-text question. Keep the existing session checks and card state unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb28828652
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bigbearcool
pushed a commit
to bigbearcool/DeepSeek-Bot
that referenced
this pull request
Oct 20, 2026
Sync Fei2411/DeepSeek-Bot dev (PR Fei2411#366 change locations, Fei2411#367 release 0.2.0, Fei2411#368 question guidance, Fei2411#369 bot message headers).
5 tasks done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #218
What changed / 改了什么
An ordinary DSH session that calls
ask_userreceives a rejection without a way to continue asking the user. The rejection now explains the next step: useask_user_questionif that tool is available in the session, or ask the question in the reply.This is the original issue's requested guidance change. The group-approval report in the discussion has a separate cause and is not claimed as fixed here.
Changelog
Ordinary sessions that try the Bot-only question tool now receive guidance to an available question tool or a plain-text question.
How I checked it / 怎么验证的
npm testinds-bot/: 746 tests, 744 passed, 2 skipped.node scripts/build-client.mjs --check.npm run lint: 0 errors; the same 11 warnings as the base branch.dev/smoke.mjs: all 41 steps passed against the pinned DSH 0.2.1-rc.2 npm CLI and scripted mock model, in a separate test home. A local launcher tracked the two processes directly; the smoke script and DSH were unmodified.Checklist / 检查