Repository navigation
Test and install against DSH 0.2.1-rc.2 - #293
Conversation
DSH 0.2.1-rc.2 is the newest release candidate, and DSH Desktop offers it as an update. The unit tests, the smoke test and the UI checks pass on it with the same results as on 0.2.0-rc.2, so the test harness, the install commands and the bench checkout move to it. npm still tags 0.2.0-rc.2 as latest, so one CI row stays on it in place of the old 0.2.1-alpha.1 row. The Docker image and the desktop app keep their own DSH pins: 0.2.1 refuses a wildcard bind address, which the image's entrypoint uses, and the app's engine profile follows its own pull request.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c6e116290
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ```sh | ||
| npx @deepseek-ai/dsh@0.2.0-rc.2 plugin --profile web add ds-bot | ||
| npx @deepseek-ai/dsh@0.2.0-rc.2 web | ||
| npx @deepseek-ai/dsh@0.2.1-rc.2 plugin --profile web add ds-bot |
There was a problem hiding this comment.
After these commands move Web users to 0.2.1-rc.2, the prominent DSH badge at README.md:12 (and its counterpart at README.zh.md:12) still advertises 0.2.0-rc.2. Readers using the badge as the current tested-version signal therefore receive contradictory guidance; update both badges as part of this version bump.
Useful? React with 👍 / 👎.
The install commands already name 0.2.1-rc.2, so the badges gave a different version.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
rahul05ranjan
left a comment
rahul05ranjan
left a comment
There was a problem hiding this comment.
The npm package exists (@deepseek-ai/dsh@0.2.1-rc.2 resolves), and the CI matrix + harness pin + docs all move together, which is the right shape for a "test and install against" bump.
One gap I hit while cross-checking: the Docker setup still installs 0.2.0-rc.2 while everything else moves to 0.2.1-rc.2. On this branch:
docker/Dockerfile:10—ARG DSH_VERSION=0.2.0-rc.2docker/compose.yml:8—DSH_VERSION: ${DSH_VERSION:-0.2.0-rc.2}docker/.env.example:41— commented default still 0.2.0-rc.2docker/README.md:168— "The image is built and tested with dsh0.2.0-rc.2"
Since the release checklist's smoke test ("Windows 10/11 x64 ... DSH Desktop, version matching the README") doesn't cover Docker, the README's "Install against 0.2.1-rc.2" claim would be silently wrong for everyone using the Docker path. Either bump these four in the same PR or note that Docker is deliberately staying one release behind.
(ds-bot/test/dsh-offer.test.js also has 0.2.0-rc.2 as a default fixture, but that's test data rather than a version pin, so no change needed there.)
Issue
None. DSH 0.2.1-rc.2 is the newest release candidate, and DSH Desktop offers it as an update.
What changed / 改了什么
ds-bot/dev/harness).latest; it takes the place of the 0.2.1-alpha.1 row.0.0.0.0), which the image's entrypoint uses, so the image needs its own change.Changelog
The install commands use DeepSeek Harness 0.2.1-rc.2.
How I checked it / 怎么验证的
npm test(inds-bot/): 648 of 648 on 0.2.1-rc.2, the same as on 0.2.0-rc.2. The released 0.1.7 also passes on 0.2.1-rc.2 (635 of 635).node scripts/build-client.mjs --checknpm run lint: 0 errors.dev/ui-shots.mjs webon both versions: every check passes. In the screenshots, one difference: the run statistics under the composer no longer show in Bot chats on 0.2.1-rc.2. ds-bot hides the composer'sactivityandusageentries, which 0.2.1 introduced in place ofstats.Checklist / 检查
src/client/changed →npm run buildran andclient.jsis committed. / 改了src/client/就已重新 build 并提交client.js。（没改src/client/）Co-authored-by. / 没有把 AI 工具写成作者或Co-authored-by。