Repository navigation
Show seconds and minutes-and-seconds in the elapsed work timer - #286
Merged
Merged
Conversation
The activity row and the group member rows waited a full minute before showing elapsed time, and `elapsedLabel` rounded everything under an hour down to whole minutes with a 1m floor (`Math.max(1, minutes)}m`). Start ticking once a second from 1s, format under a minute as `Ns` and under an hour as `Nm` or `Nm Ns`, and set `tabular-nums` on the timer spans so ticking digits keep their width.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
none (reported directly: the activity row and group member status rows only showed whole minutes starting at
1m).What changed / 改了什么
elapsedLabel(ms)now formats< 60sasNs(e.g.1s,12s),< 60masNmorNm Ns(e.g.1m,1m 8s), and>= 60masNhorNh Nm.ActivityIndicator(src/client/activity-row.js) anduseNow/since(src/client/member-status.js) now show elapsed time starting at1s(>= 1000ms) and tick once per second.font-variant-numeric: tabular-numsto.bt-typing-timeand.bt-member-stateso ticking digits keep a steady width.elapsedLabelandMemberStateintest/member-status.test.js.Changelog
Show elapsed work time in seconds (
Ns) and minutes-and-seconds (Nm Ns) instead of starting at1m.How I checked it / 怎么验证的
npm test(inds-bot/)node scripts/build-client.mjs --checknpm run lintindex.jsorsrc/host// 改了index.js或src/host/时跑冒烟测试Checklist / 检查
src/client/changed →npm run buildran andclient.jsis committed. / 改了src/client/就已重新 build 并提交client.js。Co-authored-by. / 没有把 AI 工具写成作者或Co-authored-by。