Skip to content

Add PIT HLD document , this PR replace previous PR#1014. - #1127

Open
clarklee-guizhao wants to merge 4 commits into
sonic-net:masterfrom
clarklee-guizhao:master
Open

Add PIT HLD document , this PR replace previous PR#1014.#1127
clarklee-guizhao wants to merge 4 commits into
sonic-net:masterfrom
clarklee-guizhao:master

Conversation

@clarklee-guizhao

@clarklee-guizhao clarklee-guizhao commented Nov 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Replace previous PR#1014, #1014.

  • Add clarification for platform plugins, add plan for supporting platform APIs.
  • Fix some typo.
  • Change branch name to master.
Repo PR title State
sonic-buildimage [sonic-pit] Add PIT(Platform Integration Test) feature, first commit with only framework and 2 test cases with 1 supportting platform. GitHub issue/pull request detail
sonic-buildimage [sonic-pit]Add PIT(Platform Integration Test) feature, second part, add 6 test cases. GitHub issue/pull request detail

@clarklee-guizhao clarklee-guizhao mentioned this pull request Nov 23, 2022
Closed
@clarklee-guizhao

clarklee-guizhao commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator Author

Replace previous PR#1014, #1014.

  • Add clarification for platform plugins, add plan for supporting platform APIs.
  • Fix some typo.
  • Change branch name to master.

Repo PR title State
sonic-buildimage [sonic-pit] Add PIT(Platform Integration Test) feature, first commit with only framework and 2 test cases with 1 supportting platform. GitHub issue/pull request detail
sonic-buildimage [sonic-pit]Add PIT(Platform Integration Test) feature, second part, add 6 test cases. GitHub issue/pull request detail

@zhangyanzhao @lihuay @keboliu
Hi folks, I redo this HLD PR to replace previous #1014 PR, please help review this PR for PIT, thanks a lot.

@clarklee-guizhao

clarklee-guizhao commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator Author

Also, please add @jeff-yin and @prgeor as reviews as PR#1014 :)

@zhangyanzhao

zhangyanzhao commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

@StormLiangMS this feature need be back ported to 202211

lihuay
lihuay previously approved these changes Nov 24, 2022
View reviewed changes
jeffyin-dell
jeffyin-dell reviewed Nov 29, 2022
View reviewed changes
Comment thread doc/pit/Platform_Integration_Test_high_level_design.md Outdated
@clarklee-guizhao
clarklee-guizhao requested review from jeffyin-dell and lihuay and removed request for jeffyin-dell, keboliu, lihuay and prgeor November 30, 2022 07:55
@zhangyanzhao

zhangyanzhao commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

@clarklee-guizhao can you please sign the EasyCLA? That is required before the PR can be merged. Also can you please address Jeff's comments? Thanks.

@zhangyanzhao

zhangyanzhao commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

@jeff-yin @lihuay can you please check this PR to see if you are ok to approve and merge? Thanks.

jeffyin-dell
jeffyin-dell previously approved these changes Feb 28, 2023
View reviewed changes

@jeffyin-dell jeffyin-dell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about something minor to double check. Otherwise LGTM.

Comment thread doc/pit/Platform_Integration_Test_high_level_design.md Outdated
Comment thread doc/pit/Platform_Integration_Test_high_level_design.md Outdated
@clarklee-guizhao @zhangyanzhao
Add PIT HLD document.
3d1548d 
Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
@clarklee-guizhao @zhangyanzhao
Clarify why platform plugins and plan to support Platform APIs in PITâ€Ķ
0280779 
â€Ķ HLD.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
@clarklee-guizhao @zhangyanzhao
Add example for platform-specific configuration file for PIT HLD.
00b1893 
Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
@zhangyanzhao

zhangyanzhao commented May 1, 2023

Copy link
Copy Markdown
Collaborator

added to 202305 release plan

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes
@lihuay lihuay lihuay left review comments
@jeffyin-dell jeffyin-dell jeffyin-dell left review comments

Assignees

@eddieruan-alibaba eddieruan-alibaba

Labels

None yet

Projects

SONiC 202305 Release
Status: MovedToBacklog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@clarklee-guizhao @zhangyanzhao @lguohan @lihuay @jeffyin-dell @eddieruan-alibaba