Skip to content

Modify the error message of configuring duplicate syslog to have a consistent message between versions. - #2759

Closed
chaoskao wants to merge 1 commit into
sonic-net:masterfrom
chaoskao:syslog
Closed

chaoskao wants to merge 1 commit into
sonic-net:masterfrom
chaoskao:syslog

Conversation

@chaoskao

Copy link
Copy Markdown

Modify the error message of configuring duplicate syslog to have a consistent message between versions.

What I did

Modify the error message of configuring duplicate syslog to have a consistent message between versions.

How I did it

The error message of configuring duplicate syslog is ambiguous to user, so modify it to make it have clearer meaning.

How to verify it

Modify the code and check the error message, also build the sonic-utilities python wheel to make sure all unit test cases will pass.

The error message after modification:

admin@sonic:~$ sudo config syslog add 20.1.1.12
Running command: systemctl reset-failed rsyslog-config rsyslog
Running command: systemctl restart rsyslog-config
admin@sonic:~$
admin@sonic:~$ sudo config syslog add 20.1.1.12
Usage: config syslog add [OPTIONS] SERVER_IP_ADDRESS

Error: Syslog server 20.1.1.12 is already configured.  <---------------- modified error message.

consistent message between versions.

- What I did:
Modify the error message of configuring duplicate syslog to have a
consistent message between versions.

- Why I did it:
The error message of configuring duplicate syslog is ambiguous to user,
so modify
it to make it have clearer meaning.

- How I verified it:
Modify the code and check the error message, also build the
sonic-utilities python wheel
to make sure all unit test cases will pass.

The error message after modification:
```
admin@sonic:~$ sudo config syslog add 20.1.1.12
Running command: systemctl reset-failed rsyslog-config rsyslog
Running command: systemctl restart rsyslog-config
admin@sonic:~$
admin@sonic:~$ sudo config syslog add 20.1.1.12
Usage: config syslog add [OPTIONS] SERVER_IP_ADDRESS

Error: Syslog server 20.1.1.12 is already configured.  <---------------- modified error message.
```
@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 365 days. It will be closed in 14 days if no further activity occurs.

If this PR is still relevant, please leave a comment or push a new commit — this will reset the inactivity timer.

Important: before this PR can be merged it must be rebased onto the latest master. After a year of inactivity it is almost certainly out of date and will not build or merge cleanly against the current tree. Please rebase, resolve any conflicts, and force-push so CI can re-run against current master; a PR that cannot be rebased cleanly will not be merged.

If you believe this PR should remain open regardless of activity, add the never-stale label.

Thank you for your contribution to SONiC!

@github-actions github-actions Bot added the stale label Aug 21, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request has been closed due to inactivity (no updates in over 1 year). If you would like to continue this work, please re-open the PR or submit a new one rebased onto the latest master.

Thank you for your contribution to SONiC!

@github-actions github-actions Bot closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant