Skip to content

Static Lag support changes in sonic-utilities - #2436

Closed
skannan-CLS wants to merge 5 commits into
sonic-net:masterfrom
skannan-CLS:master
Closed

skannan-CLS wants to merge 5 commits into
sonic-net:masterfrom
skannan-CLS:master

Conversation

@skannan-CLS

@skannan-CLS skannan-CLS commented Oct 11, 2022 •

Copy link
Copy Markdown

What I did

Static lag support for 202211 branch using the following md
sonic-net/SONiC#1039

other dependent pull request

https://github.com/sonic-net/sonic-buildimage/pull/12360
https://github.com/sonic-net/sonic-swss/pull/2486
https://github.com/sonic-net/sonic-utilities/pull/2436

How I did it

1. Add static lag command support in click
2. update mock_tables so pyrunner execution are success during

compilation

How to verify it

Test cases :-
        Test cases
1       Create static port channel with static flag     pass
2       verify static has option flag true or false     pass
3       Add static member see the portchannel is up     pass
4       verify teamd is created with loadbalance option by default
pass
5       Remove last portchannel member check port channel down  pass
6       Remove portchannel member check port channel still up   pass
7       verify teamdctl config dump     pass
8       verify teamdctl state dump      pass
9       shutdown the portchannel check the kernel state pass
10      no shutdown the portchannel check the kernel state      pass
11      "Check the show output matches the review comment
root@sonic:~# show inter port
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not
available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev      Protocol     Ports
-----  ------------  -----------  ------------
    1  PortChannel1  NONE(A)(Up)  Ethernet0(S)
    2  PortChannel2  NONE(A)(Up)  Ethernet8(S)
    4  PortChannel4  NONE(A)(Dw)
"       pass
12      teamnl is set to loadbalance    pass
13      save and reload and verify portchannel is up    pass
14      "docker restart teamd
teamd stopped
swss stopped
syncd stopped

swss started
syncd started
teamd started"  pass

15. verify teamd settles doesnt hog cpu with 100% cpu usage pass

Previous command output (if the output of a command-line utility has changed)

No change to previous output

New command output (if the output of a command-line utility has changed)

root@sonic:~# show inter port
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available,
S - selected, D - deselected, * - not synced
No. Team Dev Protocol Ports


1  PortChannel1  LACP(A)(Dw)
2  PortChannel2  NONE(A)(Up)  Ethernet8(S)

skannan-CLS and others added 4 commits October 11, 2022 16:19
    1. Add static lag command support in click
    2. update mock_tables so pyrunner execution are success during
compilation

    Test cases :-
            Test cases
    1       Create static port channel with static flag     pass
    2       verify static has option flag true or false     pass
    3       Add static member see the portchannel is up     pass
    4       verify teamd is created with loadbalance option by default
    pass
    5       Remove last portchannel member check port channel down  pass
    6       Remove portchannel member check port channel still up   pass
    7       verify teamdctl config dump     pass
    8       verify teamdctl state dump      pass
    9       shutdown the portchannel check the kernel state pass
    10      no shutdown the portchannel check the kernel state      pass
    11      "Check the show output matches the review comment
    root@sonic:~# show inter port
    Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not
    available,
           S - selected, D - deselected, * - not synced
      No.  Team Dev      Protocol     Ports
    -----  ------------  -----------  ------------
        1  PortChannel1  NONE(A)(Up)  Ethernet0(S)
        2  PortChannel2  NONE(A)(Up)  Ethernet8(S)
        4  PortChannel4  NONE(A)(Dw)
    "       pass
    12      teamnl is set to loadbalance    pass
    13      save and reload and verify portchannel is up    pass
    14      "docker restart teamd
    teamd stopped
    swss stopped
    syncd stopped

    swss started
    syncd started
    teamd started"  pass

    15. verify teamd settles doesnt hog cpu with 100% cpu usage pass
@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 365 days. It will be closed in 14 days if no further activity occurs.

If this PR is still relevant, please leave a comment or push a new commit — this will reset the inactivity timer.

Important: before this PR can be merged it must be rebased onto the latest master. After a year of inactivity it is almost certainly out of date and will not build or merge cleanly against the current tree. Please rebase, resolve any conflicts, and force-push so CI can re-run against current master; a PR that cannot be rebased cleanly will not be merged.

If you believe this PR should remain open regardless of activity, add the never-stale label.

Thank you for your contribution to SONiC!

@github-actions github-actions Bot added the stale label Aug 23, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This pull request has been closed due to inactivity (no updates in over 1 year). If you would like to continue this work, please re-open the PR or submit a new one rebased onto the latest master.

Thank you for your contribution to SONiC!

@github-actions github-actions Bot closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant