Repository navigation
[fgnhgorch] Changes for Fine Grained ECMP - #1315
Merged
Merged
Conversation
anish-n
marked this pull request as draft
June 4, 2020 21:24
anish-n
marked this pull request as ready for review
June 29, 2020 21:04
abdosi
reviewed
Jul 14, 2020
lguohan
reviewed
Aug 18, 2020
lguohan
reviewed
Aug 18, 2020
lguohan
reviewed
Aug 18, 2020
prsunny
reviewed
Aug 19, 2020
qiluo-msft
reviewed
Aug 21, 2020
qiluo-msft
reviewed
Aug 21, 2020
âĶOUP_ATTR_REAL_SIZE from SAI
Signed-off-by: anish-n <anish.narsian@microsoft.com>
âĶ divisible by # of buckets
qiluo-msft
reviewed
Aug 24, 2020
qiluo-msft
reviewed
Sep 12, 2020
qiluo-msft
reviewed
Sep 12, 2020
qiluo-msft
reviewed
Sep 12, 2020
qiluo-msft
reviewed
Sep 12, 2020
qiluo-msft
reviewed
Sep 12, 2020
qiluo-msft
reviewed
Sep 12, 2020
âĶ and misc. improvements
Contributor
|
@daall Could you help review tests/test_fgnhg.py. There are some |
qiluo-msft
approved these changes
Sep 29, 2020
qiluo-msft
left a comment
qiluo-msft
left a comment
Contributor
There was a problem hiding this comment.
LGTM except time.sleep(1) in tests/test_fgnhg.py
daall
approved these changes
Sep 30, 2020
Contributor
|
retest vs please |
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Oct 2, 2020
* Fine grained ECMP initial commit * Fix compilation, test failures and add logic to query SAI_NEXT_HOP_GROUP_ATTR_REAL_SIZE from SAI * Misc fixes after migrating branch * Misc-fixes * Add support to fgnhgorch for neighbor and interface availability changes * fgnhg group/prefix/member addition and deletion * fix indentation and address comment * Improve error handling and add support for crm and neigh refcounts * Temporarily disable dynamic changes to route from fine grained to standard ecmp * Add checks to limit Fine Grained ECMP to default VRF * handle fgnhg prefix addition deletion with route bulker * fix indentation * Add handling for neigh edge case scenarios and improve routeorch bulker integration * write route entry to state_db * Fix bug with add and remove nh in a bank at the same time * Improve test coverage and fix issues with multi-nh changes, misc code improvements * Improve distribution of hash buckets per nh when hash buckets are not divisible by # of buckets * Incorporate review comments v1 * Reduce exposure of private routeorch functions/variables outside of routeorch * Fix an uninitialized variable error found in testing * Change test_fgnhg.py to use the new framework to validate db entries * Remove exposure of routeorch nextHopGroupCounts outside of routeorch, and misc. improvements * camelCase changes for fgnhgorch * RouteOrch add/removeRoutePost do not need logic to reroute calls to fgnhgorch * camelCase changes v2
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Oct 2, 2020
This reverts commit fee1716.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Add FG_ROUTE_TABLE to backup database for warm reboot support for fgnhg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added fine grained ECMP changes.
Why I did it
To support consistent and layered hashing in SONiC.
How I verified it
Verified using VS swss test cases
Details if related
HLD: https://github.com/Azure/SONiC/blob/master/doc/ecmp/fine_grained_next_hop_hld.md
SAI: https://github.com/opencomputeproject/SAI/blob/master/doc/ECMP/Ordered_and_Fine_Grained_ECMP.md