Skip to content

[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch - #123

Open
mudsut4ke wants to merge 1 commit into
sonic-net:201811from
mudsut4ke:201811_qsfpdd
Open

[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch#123
mudsut4ke wants to merge 1 commit into
sonic-net:201811from
mudsut4ke:201811_qsfpdd

Conversation

@mudsut4ke

@mudsut4ke mudsut4ke commented Sep 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

[Transceiver] Add parser for QSFP-DD cable type and dictionaries for QSFP-DD codes

Picking a change from: 9e3c2da

  • Add parser for QSFP-DD cable type.
  • Add dictionaries for QSFP-DD codes.

Test result: transceiver_info_dom.log

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

@shlomibitton Wirut Getbamrung
[Transceiver] Add parser for QSFP-DD cable type and dictionaries for …
9e3c2da 
…QSFP-DD codes (sonic-net#101)

- Add parser for QSFP-DD cable type.
- Add dictionaries for QSFP-DD codes.

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
@zhenggen-xu

zhenggen-xu commented Oct 5, 2020

Copy link
Copy Markdown

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@mudsut4ke

mudsut4ke commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM

I have attached test results to in PR info already, please review it

@zhenggen-xu

zhenggen-xu commented Oct 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM

I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@mudsut4ke

mudsut4ke commented Oct 9, 2020

Copy link
Copy Markdown
Contributor Author

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu ,
sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,

So I need this qsfpdd_dom to be a dom decoder on our device
here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

@zhenggen-xu

zhenggen-xu commented Oct 9, 2020

Copy link
Copy Markdown

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu ,
sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,

So I need this qsfpdd_dom to be a dom decoder on our device
here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.

@mudsut4ke

mudsut4ke commented Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM
I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu ,
sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,
So I need this qsfpdd_dom to be a dom decoder on our device
here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.

@zhenggen-xu , Sure, I will do

@zhenggen-xu

zhenggen-xu commented Oct 19, 2020

Copy link
Copy Markdown

Did you make any changes other than #101?
If not, we should cherry-pick that into 201811 without a new PR.

@mudsut4ke

mudsut4ke commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

@zhenggen-xu , no change
I just cherry-pick commit from #101

@mudsut4ke

mudsut4ke commented Oct 26, 2020

Copy link
Copy Markdown
Contributor Author

@zhenggen-xu , Can you merge this one ?

@jleveque
jleveque requested a review from lguohan November 4, 2020 18:46
@jleveque

jleveque commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

@lguohan: This PR introduces a new feature to the stable 201811 branch. What are your feelings?

@prgeor

prgeor commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

@mudsut4ke can we close this PR?

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@zzhiyuan Zhi Yuan Carl Zhao
[xcvrd] Fix xcvrd crash on other port prefixes (sonic-net#123)
b9381a5 
Implement a better check for logical_port_name_to_physical_port_list function.

Currently it will only accept names that start with "Ethernet". If we try to add other ports it will crash.

In the future Arista will implement other port types. For example "Recirc0".

Co-authored-by: Zhi Yuan Carl Zhao <zyzhao@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan Awaiting requested review from lguohan

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mudsut4ke @zhenggen-xu @jleveque @prgeor @shlomibitton