Repository navigation
Makefile: Optimization - #6864
Open
donNewtonAlpha wants to merge 1 commit into
Open
donNewtonAlpha wants to merge 1 commit into
donNewtonAlpha wants to merge 1 commit into
Conversation
* Fix if/else/endif logic * To only target a single build environment Signed-off-by: Don Newton don@opennetworking.org
donNewtonAlpha
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
February 23, 2021 16:00
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Don Newton don@opennetworking.org
Why I did it
To speed up new build environment setup / save disk space
To speed up builds
Currently if NOJESSIE and NOSTRETCH are unset
make configurewill build 3 separate build imagesHow I did it
Arranged
if,elseandendifstatement such that only one will be entered per invocationHow to verify it
On a clean environment with NOJESSIE and NOSTRETCH unset execute
make configure PLATFORM=$platform_of_choice- only the jessie build environment will be createdWhich release branch to backport (provide reason below if selected)
ONF is currently using the 202012 branch as our base for our p4 project
Description for the changelog
Only build / use one of jessie, stretch or buster
A picture of a cute animal (not mandatory but encouraged)