Skip to content

[Mellanox] Add support for set/get system led status - #4829

Merged
jleveque merged 3 commits into
sonic-net:masterfrom
Junchao-Mellanox:system-led-api
Jul 13, 2020
Merged

jleveque merged 3 commits into
sonic-net:masterfrom
Junchao-Mellanox:system-led-api

Conversation

@Junchao-Mellanox

Copy link
Copy Markdown
Collaborator

- Why I did it

System health feature needs to set/get system led status

- How I did it

  1. Add a led object in chassis class and initialize it when the API is called on host side
  2. Read/write system led system fs to get/set the status

- How to verify it

Manual test on SN2700

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox

Copy link
Copy Markdown
Collaborator Author

Retest vsimage please

@sujinmkang

Copy link
Copy Markdown
Collaborator

@Junchao-Mellanox Can we just read "/var/run/hw-management/led/led_status" for the get_status()?

@Junchao-Mellanox

Copy link
Copy Markdown
Collaborator Author

@Junchao-Mellanox Can we just read "/var/run/hw-management/led/led_status" for the get_status()?

No, we cannot for now because driver doesn't put the LED status to that file as I tested.

@Junchao-Mellanox

Copy link
Copy Markdown
Collaborator Author

Retest vsimage please.

@keboliu

keboliu commented Jul 7, 2020

Copy link
Copy Markdown
Collaborator

retest vsimage please

@keboliu
keboliu requested a review from jleveque July 13, 2020 09:59
@jleveque
jleveque merged commit 76d68ad into sonic-net:master Jul 13, 2020
@Junchao-Mellanox
Junchao-Mellanox deleted the system-led-api branch September 18, 2020 05:44
mssonicbld added a commit that referenced this pull request Sep 5, 2026
…atically (#29194)

#### Why I did it
src/sonic-utilities
```
* 6946bbf7 - (HEAD -> master, origin/master, origin/HEAD) [generic_config_updater]: Preserve command log format (#4831) (4 hours ago) [yijingyan2]
* 2747f448 - [route_check] Normalize VNET host prefixes and safely filter IP2ME routes (#4829) (28 hours ago) [Mike Dubrovsky]
* 6c9acc26 - Add reusable disk-space validation helper for image installation and reboot (#4598) (30 hours ago) [rameshraghupathy]
* 8a11cb16 - [Multi-ASIC] Added fast-reboot support for multi-asic (#4506) (30 hours ago) [Amit Abel]
* 226586f3 - [sonic-installer] Enroll image db certificate before Secure Boot verification (#4700) (2 days ago) [elybarneams]
* d75e732f - syslog: Replace shell-based container lookup with exact matching (#4832) (2 days ago) [Ashutosh Agrawal]
* 9aaae12f - [counterpoll] Fix bash tab-completion by not requiring CONFIG_DB at import (#4803) (2 days ago) [Yizhen Zhang]
* 097712c6 - [CLI] [show] Added CLI to show label-port interfaces mapping and status (#4500) (2 days ago) [‪Zili Bombach‬‏]
* 8c1d550b - [neighbor_advertiser] Set explicit pipe VXLAN TTL mode (#4788) (3 days ago) [Mike Dubrovsky]
* 1ba80ce4 - [pfcwd] Scale start_default timers off PFC-enabled ports only (#4775) (4 days ago) [arawat-nexthop]
* 45bd50e1 - Adding infra for hardening of external containers (#4765) (5 days ago) [David Rozenblum]
* 580a3beb - [show]: Fix 'show storm-control -n <namespace>' crash on multi-ASIC platforms (#4687) (7 days ago) [Vasundhara Volam]
* aef18a8a - refactor: command_wrapper takes List[str] instead of format string (#4805) (9 days ago) [xq9mend]
* ee734171 - [multi-ASIC] counterpoll flowcnt-route namespace-aware capability check (#4604) (10 days ago) [DavidZagury]
* b8d3131f - [generic_config_updater] validate VLAN interface data (#4800) (10 days ago) [Ashutosh Agrawal]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants