Skip to content

Build bmp container into sonic-buildimage - #18946

Merged
qiluo-msft merged 49 commits into
sonic-net:masterfrom
FengPan-Frank:bmp_init
Nov 22, 2024
Merged

Build bmp container into sonic-buildimage#18946
qiluo-msft merged 49 commits into
sonic-net:masterfrom
FengPan-Frank:bmp_init

Conversation

@FengPan-Frank

@FengPan-Frank FengPan-Frank commented May 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why I did it

Build bmp container into sonic-buildimage, and added relevant daemon/file handling.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Build bmp container into sonic-buildimage, and added relevant daemon/file handling.

How to verify it

Local build successfully and verified in lab DUT.

image image

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@FengPan-Frank
FengPan-Frank requested review from qiluo-msft and removed request for qiluo-msft May 13, 2024 13:31
This was referenced May 13, 2024
Merged
Merged
@FengPan-Frank

FengPan-Frank commented May 15, 2024

Copy link
Copy Markdown
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines

azure-pipelines Bot commented May 15, 2024

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 18946 in repo sonic-net/sonic-buildimage

@FengPan-Frank

FengPan-Frank commented May 16, 2024

Copy link
Copy Markdown
Contributor Author

/azpw ms_conflict

qiluo-msft
qiluo-msft reviewed May 16, 2024
View reviewed changes
Comment thread dockers/docker-sonic-bmp/critical_processes Outdated
qiluo-msft
qiluo-msft reviewed May 16, 2024
View reviewed changes
Comment thread dockers/docker-sonic-bmp/docker_init.sh Outdated
qiluo-msft
qiluo-msft reviewed May 16, 2024
View reviewed changes
Comment thread rules/config Outdated
@lguohan lguohan added the BMP Bgp Monitor Container label May 18, 2024
@forrestchu

forrestchu commented Jun 24, 2024

Copy link
Copy Markdown

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.

Add INCLUDE_BMP to indicate whether to build bmp container Add docker file for bmp, as well as agent used openbmpd/bmpcfgd. Add template file for bmp container services. Add entry for bmp to FEATURE table in config_db.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI?

qiluo-msft
qiluo-msft reviewed Sep 19, 2024
View reviewed changes
Comment thread files/build_templates/init_cfg.json.j2 Outdated
@FengPan-Frank

FengPan-Frank commented Nov 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.
Add INCLUDE_BMP to indicate whether to build bmp container Add docker file for bmp, as well as agent used openbmpd/bmpcfgd. Add template file for bmp container services. Add entry for bmp to FEATURE table in config_db.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI?

it's 5000, pls refer HLD section https://github.com/sonic-net/SONiC/blob/50cb55989649d5392b48b54bb7ca8263c883e162/doc/bmp/bmp.md#config-file-update

@FengPan-Frank
fix submodule
fdecfb0
@FengPan-Frank
Merge branch 'sonic-net:master' into bmp_init
22ad972
@FengPan-Frank
skip bmpcfgd test temporarily
808f8c0
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
d1c3e10 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
cd6af6f 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
9d8b842 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
b48c9a4 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
676b867 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
b13fe8e 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
0f9b171 
â€Ķldimage into bmp_init
@FengPan-Frank
Launch bmp container by default
f140130
@FengPan-Frank
Merge branch 'sonic-net:master' into bmp_init
c70e767
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
d92aaca 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
d17acb2 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
45d9fff 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
cfc4d2b 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
c3db6bd 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
6841079 
â€Ķldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-buiâ€Ķ
47bb5b6 
â€Ķldimage into bmp_init
FengPan-Frank
FengPan-Frank commented Nov 21, 2024
View reviewed changes

@FengPan-Frank FengPan-Frank left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonic-net/sonic-host-services#128, bmpcfgd unittest passed in sonic-host-services before.

qiluo-msft
qiluo-msft reviewed Nov 21, 2024
View reviewed changes
Comment thread files/image_config/rsyslog/rsyslog.d/00-sonic.conf.j2
@qiluo-msft
qiluo-msft merged commit f8a78c1 into sonic-net:master Nov 22, 2024
@mlok-nokia mlok-nokia mentioned this pull request Dec 1, 2024
Closed
11 tasks
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@FengPan-Frank @VladimirKuk
Build bmp container into sonic-buildimage (sonic-net#18946)
0f2d6bf 
Why I did it
Build bmp container into sonic-buildimage, and added relevant daemon/file handling.

Work item tracking
Microsoft ADO (number only):27588893
How I did it
Build bmp container into sonic-buildimage, and added relevant daemon/file handling.

How to verify it
Local build successfully and verified in lab DUT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes
@xincunli-sonic xincunli-sonic xincunli-sonic approved these changes
@xumia xumia Awaiting requested review from xumia xumia is a code owner
@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

BMP Bgp Monitor Container

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FengPan-Frank @forrestchu @qiluo-msft @xincunli-sonic @lguohan